lkml.org 
[lkml]   [2013]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 01/18] tty: Don't change receive_room for ioctl(TIOCSETD)
    Date
    tty_set_ldisc() is guaranteed exclusive use of the line discipline
    by tty_ldisc_lock_pair_timeout(); shutting off input by resetting
    receive_room is unnecessary.

    Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
    ---
    drivers/tty/tty_ldisc.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
    index ba49c0e..5a6c43d 100644
    --- a/drivers/tty/tty_ldisc.c
    +++ b/drivers/tty/tty_ldisc.c
    @@ -537,9 +537,6 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc)
    return 0;
    }

    - /* FIXME: why 'shutoff' input if the ldisc is locked? */
    - tty->receive_room = 0;
    -
    old_ldisc = tty->ldisc;
    tty_lock(tty);

    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-03-27 14:21    [W:4.088 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site