lkml.org 
[lkml]   [2013]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 4/4] f2fs: fix to give correct parent inode number for roll forward
    From
    >   */
    > -static inline void set_cold_file(struct f2fs_sb_info *sbi, struct inode
    > *inode,
    > +static inline void set_cold_files(struct f2fs_sb_info *sbi, struct inode
    > *inode,
    > const unsigned char *name)
    > {
    > int i;
    > @@ -108,7 +109,7 @@ static inline void set_cold_file(struct f2fs_sb_info
    > *sbi, struct inode *inode,
    > int count = le32_to_cpu(sbi->raw_super->extension_count);
    > for (i = 0; i < count; i++) {
    > if (!is_multimedia_file(name, extlist[i])) {
    > - F2FS_I(inode)->i_advise |= FADVISE_COLD_BIT;
    > + set_cold_file(inode);
    > break;
    > }
    > }
    It is just my private opinion.
    How about use this name "set_cold_file_from_list instead of set_cold_files ?

    Thanks.


    \
     
     \ /
      Last update: 2013-03-27 03:01    [W:2.436 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site