lkml.org 
[lkml]   [2013]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 71/98] ext4: use s_extent_max_zeroout_kb value as number of kb
    Date
    3.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lukas Czerner <lczerner@redhat.com>

    commit 4f42f80a8f08d4c3f52c4267361241885d5dee3a upstream.

    Currently when converting extent to initialized, we have to decide
    whether to zeroout part/all of the uninitialized extent in order to
    avoid extent tree growing rapidly.

    The decision is made by comparing the size of the extent with the
    configurable value s_extent_max_zeroout_kb which is in kibibytes units.

    However when converting it to number of blocks we currently use it as it
    was in bytes. This is obviously bug and it will result in ext4 _never_
    zeroout extents, but rather always split and convert parts to
    initialized while leaving the rest uninitialized in default setting.

    Fix this by using s_extent_max_zeroout_kb as kibibytes.

    Signed-off-by: Lukas Czerner <lczerner@redhat.com>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/extents.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ext4/extents.c
    +++ b/fs/ext4/extents.c
    @@ -3278,7 +3278,7 @@ static int ext4_ext_convert_to_initializ

    if (EXT4_EXT_MAY_ZEROOUT & split_flag)
    max_zeroout = sbi->s_extent_max_zeroout_kb >>
    - inode->i_sb->s_blocksize_bits;
    + (inode->i_sb->s_blocksize_bits - 10);

    /* If extent is less than s_max_zeroout_kb, zeroout directly */
    if (max_zeroout && (ee_len <= max_zeroout)) {



    \
     
     \ /
      Last update: 2013-03-27 01:01    [W:4.924 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site