Messages in this thread | | | Date | Tue, 26 Mar 2013 15:50:48 +0800 | Subject | Re: [PATCH RFC/RFT] regulator: ab8500: Remove is_enabled from struct ab8500_regulator_info | From | Axel Lin <> |
| |
2013/3/26 Bengt Jönsson <bengt.g.jonsson@stericsson.com>: > On 03/26/2013 07:50 AM, Axel Lin wrote: >> >> The is_enabled flag looks not necessary at all, it also introduces some >> issues >> because current code updates info->is_enabled flag in error paths of >> ab8500_regulator_enable() and ab8500_regulator_disable(). >> Thus this patch removes is_enabled from struct ab8500_regulator_info. >> >> This patch also removes info->is_enabled checking in >> ab8500_regulator_set_mode(), >> so it allows setting mode even the regulator is disabled. > > This patch will change the behaviour of set_mode as the ab8500 regulators > share mode and enable in the same register bits: > - off = 0b00 > - low power mode= 0b11 > - full powermode = 0b01 > - (HW control mode = 0b10) > > To keep regulator_enable/disable apart from regulator_set_mode I think this > patch should not go in.
Thanks for the review. I'll send a patch to avoid update is_enabled flag in error paths.
Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |