Messages in this thread | | | Date | Tue, 26 Mar 2013 20:14:44 +0100 | From | Richard Cochran <> | Subject | Re: [PATCH 0/8] Move ntp state to be protected by timekeeping lock |
| |
On Mon, Mar 25, 2013 at 01:08:10PM -0700, John Stultz wrote:
> This patchset makes the lock ownership lines less obvious, but I've > been sure to keep the ntp state static to ntp.c and instead provided > some accessors via ntp-internal.h that timekeping code can use to > make changes. The only really ugly part is that do_adjtimex() has > to split some of the logic between timekeeping.c and ntp.c in order > to really get the locking done correctly.
I didn't find this too ugly or troublesome. The reshuffling you have here looks straightforward to me.
Thanks, Richard
| |