lkml.org 
[lkml]   [2013]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 4/4] uprobes/powerpc: remove additional trap instruction check
    * Ananth N Mavinakayanahalli <ananth@in.ibm.com> [2013-03-22 20:49:46]:

    > From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
    >
    > prepare_uprobe() already checks if the underlying unstruction
    > (on file) is a trap variant. We don't need to check this again.
    >
    > Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>

    Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

    > ---
    > arch/powerpc/kernel/uprobes.c | 6 ------
    > 1 file changed, 6 deletions(-)
    >
    > Index: linux-3.9-rc3/arch/powerpc/kernel/uprobes.c
    > ===================================================================
    > --- linux-3.9-rc3.orig/arch/powerpc/kernel/uprobes.c
    > +++ linux-3.9-rc3/arch/powerpc/kernel/uprobes.c
    > @@ -53,12 +53,6 @@ int arch_uprobe_analyze_insn(struct arch
    > if (addr & 0x03)
    > return -EINVAL;
    >
    > - /*
    > - * We currently don't support a uprobe on an already
    > - * existing breakpoint instruction underneath
    > - */
    > - if (is_trap(auprobe->ainsn))
    > - return -ENOTSUPP;
    > return 0;
    > }
    >

    --
    Thanks and Regards
    Srikar Dronamraju



    \
     
     \ /
      Last update: 2013-03-26 14:01    [W:5.047 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site