Messages in this thread | | | Date | Sun, 24 Mar 2013 08:43:31 +0100 | From | Ingo Molnar <> | Subject | Re: [patch] mm: speedup in __early_pfn_to_nid |
| |
* Russ Anderson <rja@sgi.com> wrote:
> --- linux.orig/mm/page_alloc.c 2013-03-19 16:09:03.736450861 -0500 > +++ linux/mm/page_alloc.c 2013-03-22 17:07:43.895405617 -0500 > @@ -4161,10 +4161,23 @@ int __meminit __early_pfn_to_nid(unsigne > { > unsigned long start_pfn, end_pfn; > int i, nid; > + /* > + NOTE: The following SMP-unsafe globals are only used early > + in boot when the kernel is running single-threaded. > + */ > + static unsigned long last_start_pfn, last_end_pfn; > + static int last_nid;
I guess I'm the nitpicker of the week:
please use the customary (multi-line) comment style:
/* * Comment ..... * ...... goes here. */
specified in Documentation/CodingStyle.
Thanks,
Ingo
| |