lkml.org 
[lkml]   [2013]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 014/104] rtnl: fix info leak on RTM_GETLINK request for VF devices
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mathias Krause <minipli@googlemail.com>

    [ Upstream commit 84d73cd3fb142bf1298a8c13fd4ca50fd2432372 ]

    Initialize the mac address buffer with 0 as the driver specific function
    will probably not fill the whole buffer. In fact, all in-kernel drivers
    fill only ETH_ALEN of the MAX_ADDR_LEN bytes, i.e. 6 of the 32 possible
    bytes. Therefore we currently leak 26 bytes of stack memory to userland
    via the netlink interface.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/core/rtnetlink.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/core/rtnetlink.c
    +++ b/net/core/rtnetlink.c
    @@ -973,6 +973,7 @@ static int rtnl_fill_ifinfo(struct sk_bu
    * report anything.
    */
    ivi.spoofchk = -1;
    + memset(ivi.mac, 0, sizeof(ivi.mac));
    if (dev->netdev_ops->ndo_get_vf_config(dev, i, &ivi))
    break;
    vf_mac.vf =



    \
     
     \ /
      Last update: 2013-03-25 03:41    [W:8.770 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site