Messages in this thread Patch in this message | | | Date | Sun, 24 Mar 2013 19:21:18 +0100 | From | Oleg Nesterov <> | Subject | [PATCH 3/5] uprobes: Kill the unnecesary filp != NULL check in __copy_insn() |
| |
__copy_insn(filp) can only be called after valid_vma() returns T, vma->vm_file passed as "filp" can not be NULL.
Signed-off-by: Oleg Nesterov <oleg@redhat.com> --- kernel/events/uprobes.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 0a759c6..e5d479f 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -478,9 +478,6 @@ __copy_insn(struct address_space *mapping, struct file *filp, char *insn, { struct page *page; - if (!filp) - return -EINVAL; - if (!mapping->a_ops->readpage) return -EIO; /* -- 1.5.5.1
| |