lkml.org 
[lkml]   [2013]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tile: ns2cycles should use __raw_get_cpu_var
On 3/23/2013 3:23 AM, Henrik Austad wrote:
> + /* we don't have to disable preemptions here as each core has the same
> + * clock-frequency */

Looks OK except the comment is in the wrong style. Kernel multiline comments

/*
* Should look
* like this.
*/

and use full sentences with punctuation. (Also, don't hyphenate clock frequency here.) Thanks!

--
Chris Metcalf, Tilera Corp.
http://www.tilera.com



\
 
 \ /
  Last update: 2013-03-23 15:21    [W:0.047 / U:2.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site