Messages in this thread | | | Date | Fri, 22 Mar 2013 16:36:50 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH] mach_omap2: use PTR_RET instead of IS_ERR + PTR_ERR |
| |
On Wed, Mar 20, 2013 at 01:28:47PM -0500, Jon Hunter wrote: > Sorry I am now not sure I follow you here. Someone just pointed out to > me that PTR_RET() is defined as ... > > static inline int __must_check PTR_RET(const void *ptr) > { > if (IS_ERR(ptr)) > return PTR_ERR(ptr); > else > return 0; > } > > So the above change appears to be equivalent. Is there something that is > wrong with the current implementation that needs to be fixed?
No - I misread it as PTR_ERR not PTR_RET. Your patch is fine.
| |