Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] drivers: cpuidle: kirkwood: fix coccicheck warnings | Date | Fri, 22 Mar 2013 14:22:05 +0100 |
| |
On Friday, March 22, 2013 02:12:55 AM Silviu-Mihai Popescu wrote: > Convert all uses of devm_request_and_ioremap() to the newly introduced > devm_ioremap_resource() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages so all explicit > error messages can be removed from the failure code paths. > > Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Applied to linux-pm.git/bleeding-edge and will be moved to linux-next after build testing.
Thanks, Rafael
> --- > drivers/cpuidle/cpuidle-kirkwood.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c > index 670aa1e..53aad73 100644 > --- a/drivers/cpuidle/cpuidle-kirkwood.c > +++ b/drivers/cpuidle/cpuidle-kirkwood.c > @@ -66,9 +66,9 @@ static int kirkwood_cpuidle_probe(struct platform_device *pdev) > if (res == NULL) > return -EINVAL; > > - ddr_operation_base = devm_request_and_ioremap(&pdev->dev, res); > - if (!ddr_operation_base) > - return -EADDRNOTAVAIL; > + ddr_operation_base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(ddr_operation_base)) > + return PTR_ERR(ddr_operation_base); > > device = &per_cpu(kirkwood_cpuidle_device, smp_processor_id()); > device->state_count = KIRKWOOD_MAX_STATES; > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |