Messages in this thread | | | Date | Thu, 21 Mar 2013 21:36:15 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 02/11] ARM: remove extra timer-sp control register clearing |
| |
On 03/21/2013 02:23 PM, Russell King - ARM Linux wrote: > On Wed, Mar 20, 2013 at 05:54:02PM -0500, Rob Herring wrote: >> From: Rob Herring <rob.herring@calxeda.com> >> >> The timer-sp initialization code clears the control register before >> initializing the timers, so every platform doing this is redundant. >> >> For unused timers, we should not care what state they are in. > > NAK. We do care what state they're in. What if they have their interrupt > enable bit set, and IRQ is shared with the clock event timer? > > No, this patch is just wrong.
Okay, I can have the timer init function clear the register in the case that even when the timer is unused.
Rob
| |