Messages in this thread | | | Date | Thu, 21 Mar 2013 18:40:49 +0000 | From | Pádraig Brady <> | Subject | Re: [PATCH v2 2/7] watchdog: w83627hf: Enable watchdog only once |
| |
On 03/19/2013 08:02 PM, Guenter Roeck wrote: > On Tue, Mar 19, 2013 at 05:26:26PM +0000, Pádraig Brady wrote: >> On 03/10/2013 11:14 PM, Guenter Roeck wrote: >>> It is unnecessary to enable the logical device and WDT0 each time >>> the watchdog is accessed. Do it only once during initialization. >> >> Is this also the case on systems where the superio >> chip is used for other things? I've the impression >> that this may break some systems (though I no longer >> have the hardware to test). Arbitration of multiple >> users of the superio device may be managed be a central >> user space app, or by a kernel level arbitrator. >> > Not sure if I understand you correctly. > > You mean some entity might actually disable the watchdog between accesses > to it by the watchdog driver ? That would make it pretty useless. > Might as well turn it off entirely if that is the case. > > Or do you refer to _selecting_ the hwmon logical device ? If so, this patch > is about enabling it only once, not about selecting it only once.
I meant selecting. Enabling only once is fine.
sorry for the noise,
thanks, Pádraig. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |