Messages in this thread | | | Date | Thu, 21 Mar 2013 15:24:15 +0200 | From | Heikki Krogerus <> | Subject | Re: [PATCH 2/2] serial: of_serial: Handle fifosize property |
| |
Hi,
On Thu, Mar 21, 2013 at 07:41:39PM +0800, Ley Foon Tan wrote: > On Thu, 2013-03-21 at 12:48 +0200, Heikki Krogerus wrote: > > + /* Check for fifo size */ > > + if (of_property_read_u32(np, "fifosize", &prop) == 0) > > + port->fifosize = prop; > > + > Suggest to use "fifo-size" for the device tree property, to align with > other DT properties.
I was going to, but then I noticed that in some .dtsi files "fifosize" is used with uarts. Should I still change it?
> > port->irq = irq_of_parse_and_map(np, 0); > > port->iotype = UPIO_MEM; > > if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > > I think you need to remove the UPF_FIXED_TYPE from port-flags as well to > use the fifo size from device tree. Otherwise, it will get from the > static array in 8250.c.
No, it's the other way around. It is picked from the array conditionally, only in case it was not already set. However, if UPF_FIXED_TYPE is removed then autoconfig() will override it.
Thanks,
-- heikki
| |