Messages in this thread | | | Date | Thu, 21 Mar 2013 12:52:30 +0000 | From | Thomas Graf <> | Subject | Re: [PATCH 2/2] netlink: Diag core and basic socket info dumping |
| |
On 03/21/13 at 01:21pm, Andrey Vagin wrote: > diff --git a/include/uapi/linux/netlink_diag.h b/include/uapi/linux/netlink_diag.h > new file mode 100644 > index 0000000..9328866 > --- /dev/null > +++ b/include/uapi/linux/netlink_diag.h > +enum { > + NETLINK_DIAG_MEMINFO, > + NETLINK_DIAG_GROUPS, > + > + NETLINK_DIAG_MAX, > +};
Please follow the common pattern and define NETLINK_DIAG_MAX as NETLINK_DIAG_GROUPS like other by doing>
[...] __NETLINK_DIAG_MAX, }; #define NETLINK_DIAG_MAX (__NETLINK_DIAG_MAX - 1) Everyone is used to do: struct nlattr *attrs[NETLINK_DIAG_MAX+1]; nla_parse([...], NETLINK_DIAG_MAX, [...]
In fact, the follow-up patch to ss is buggy because of this. UNIX_DIAG_MAX suffers from the same problem which is problem the cause for this.
| |