Messages in this thread | | | Date | Thu, 21 Mar 2013 12:28:35 +0100 | From | Ingo Molnar <> | Subject | Re: Basic perf PMU support for Haswell v9 |
| |
* Andi Kleen <andi@firstfloor.org> wrote:
> This is based on v7 of the full Haswell PMU support, > rebased, reviewer-optimized and stripped down to the bare bones > > Most interesting new features are not in this patchkit > (full version is git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git hsw/pmu5) > > Contains support for: > - Basic Haswell PMU and PEBS support > - Late unmasking of the PMI > - Basic LBRv4 support > > v2: Addressed Stephane's feedback. See individual patches for details. > v3: now even more bite-sized. Qualifier constraints merged earlier. > v4: Rename some variables, add some comments and other minor changes. > Add some Reviewed/Tested-bys. > v5: Address some minor review feedback. Port to latest perf/core > v6: Add just some variable names, add comments, edit descriptions, some > more testing, rebased to latest perf/core > v7: Expand comment > v8: Rename structure field. > v9: No wide counters, but add basic LBRs. Add some more > constraints. Rebase to 3.9rc1
I had another look at your latest patches and they are still quite sloppy: you never ran them through checkpatch.pl, right? Tons of warnings, quite a few of which are legitimate.
These are all basic kernel hacking 101 mistakes you commited and we are already into version 9 of your patch-set ...
Having to point out trivial errors in your patches again and again is not a very efficient use of my time, frankly.
Thanks,
Ingo
| |