Messages in this thread | | | Date | Thu, 21 Mar 2013 10:46:26 +0100 | From | Nicolas Ferre <> | Subject | Re: [PATCH] rtc: rtc-at91rm9200: use a variable for storing IMR |
| |
On 03/20/2013 10:50 PM, Andrew Morton : > On Fri, 15 Mar 2013 18:37:12 +0100 Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > >> On some revisions of AT91 SoCs, the RTC IMR register is not working. >> Instead of elaborating a workaround for that specific SoC or IP version, >> we simply use a software variable to store the Interrupt Mask Register and >> modify it for each enabling/disabling of an interrupt. The overhead of this >> is negligible anyway. > > This description doesn't really allow me or others to work out whether > the fix should be included in 3.9 or backported into earlier kernels. > > So please, when fixing a bug do include a full description of the > user-visible effects of that bug. And your opinion regarding the > -mainline and -stable decision is always useful.
Yes, sure.
Concerning this patch, we can imagine to push it upstream as a bugfix for 3.9-rc. It is not a regression because... well... it has never worked properly on the affected SoC family.
For -stable, we can add this tag:
Cc: stable <stable@vger.kernel.org> [v3.8+]
As this patch applies up to this revision. For other kernel releases, I will need to rework the patch a little bit due to files name modifications.
Thanks, best regards, -- Nicolas Ferre
| |