lkml.org 
[lkml]   [2013]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tracepoints: prevents null probe from being added
From
Date
On Wed, 2013-03-20 at 14:01 -0400, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@goodmis.org) wrote:
> > On Wed, 2013-03-20 at 12:18 +0900, kpark3469@gmail.com wrote:
> > > From: Sahara <keun-o.park@windriver.com>
> > >
> > > Somehow tracepoint_entry_add/remove_probe functions allow a null probe
> > > function.
> >
> > You actually hit this in practice, or is this just something that you
> > observe from code review?
> >
> > > Especially on getting a null probe in remove function, it seems
> > > to be used to remove all probe functions in the entry.
> >
> > Hmm, that actually sounds like a feature.
>
> Yep. It's been a long time since I wrote this code, but the removal code
> seems to use NULL probe pointer to remove all probes for a given
> tracepoint.
>
> I'd be tempted to just validate non-NULL probe within
> tracepoint_entry_add_probe() and let other sites as is, just in case
> anyone would be using this feature.
>
> I cannot say that I have personally used this "remove all" feature much
> though.
>

I agree. I don't see anything wrong in leaving the null probe feature in
the removal code. But updating the add code looks like a proper change.

-- Steve




\
 
 \ /
  Last update: 2013-03-21 01:01    [W:0.039 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site