Messages in this thread | | | Date | Wed, 20 Mar 2013 23:36:19 +0100 | From | Sylwester Nawrocki <> | Subject | Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework |
| |
Hi Kishon,
On 03/20/2013 10:12 AM, Kishon Vijay Abraham I wrote: > The PHY framework provides a set of APIs for the PHY drivers to > create/destroy a PHY and APIs for the PHY users to obtain a reference to the > PHY with or without using phandle. To obtain a reference to the PHY without > using phandle, the platform specfic intialization code (say from board file) > should have already called phy_bind with the binding information. The binding > information consists of phy's device name, phy user device name and an index. > The index is used when the same phy user binds to mulitple phys. > > PHY drivers should create the PHY by passing phy_descriptor that has > describes the PHY (label, type etc..) and ops like init, exit, suspend, resume, > poweron, shutdown. > > The documentation for the generic PHY framework is added in > Documentation/phy.txt and the documentation for the sysfs entry is added > in Documentation/ABI/testing/sysfs-class-phy. > > Signed-off-by: Kishon Vijay Abraham I<kishon@ti.com> > --- [...] > +static inline struct phy *phy_get(struct device *dev, int index) > +{ > + return ERR_PTR(-EOPNOTSUPP);
Shouldn't these be -ENOSYS ? EOPNOTSUPP is defined by POSIX as "Operation not supported on socket". And EOPNOTSUPP appears to be mostly used in the network code in the kernel.
> +} > + > +static inline struct phy *devm_phy_get(struct device *dev, int index) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline struct phy *of_phy_get(struct device *dev, int index) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline struct phy *devm_of_phy_get(struct device *dev, int index) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline struct phy *of_phy_get_byname(struct device *dev, > + const char *string) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline struct phy *devm_of_phy_get_byname(struct device *dev, > + const char *string) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +}
Thanks, Sylwester
| |