Messages in this thread | | | Date | Wed, 20 Mar 2013 15:24:32 +0800 | From | Wanlong Gao <> | Subject | Re: [PATCH V5 4/5] virtio-scsi: introduce multiqueue support |
| |
On 03/20/2013 09:46 AM, Venkatesh Srinivas wrote: > This looks pretty good! > > I rather like the (lack of) locking in I/O completion (around the req > count vs. target/queue binding). It is unfortunate that you need to hold the per-target lock in virtscsi_pick_vq() though; have any idea > how much that lock hurts?
Paolo?
> > Just two minor comments: > > (in struct virtio_scsi_target_data): > + /* This spinlock never help at the same time as vq_lock. */ > ^^^^ held? > > (in struct virtio_scsi): > + /* Does the affinity hint is set for virtqueues? */ > Could you rephrase that, please?
Thank you, fixed in V6, please review.
> > Tested on qemu and w/ Google Compute Engine's virtio-scsi device.
Cool.
> > Reviewed-and-tested-by: Venkatesh Srinivas <venkateshs@google.com>
Do you mind review and test the V6? Thank you.
Regards, Wanlong Gao
> > Thanks, > -- vs; >
| |