Messages in this thread | | | From | H Hartley Sweeten <> | Date | Wed, 20 Mar 2013 11:06:16 -0500 | Subject | RE: [PATCH] Staging: comedi: serial2002: fixed consistent spacing issue |
| |
On Wednesday, March 20, 2013 9:04 AM, Joe Perches wrote: > On Wed, 2013-03-20 at 15:29 +0000, Al Viro wrote: >> On Wed, Mar 20, 2013 at 03:47:53PM +0300, Dan Carpenter wrote: >> >>> The original code here needs to broken up into functions so it isn't >>> squashed up against the 80 character limit. >> >> I'd say what needs to be done to the original code... > > All good things, thanks for taking the time to write it Al. > Not that I'm ever touching comedi code, but Hartley is, so > I'm adding him to cc just in case he didn't see it...
I saw it.
I haven't touched this driver yet because I haven't worked out a clean way to fix the sparse warnings in it.
I'll get to it eventually. :-)
Regards, Hartley
| |