Messages in this thread | | | Date | Wed, 20 Mar 2013 23:26:10 +0800 | Subject | Re: [PATCH 09/10] workqueue: implement NUMA affinity for unbound workqueues | From | Lai Jiangshan <> |
| |
On Wed, Mar 20, 2013 at 11:05 PM, Tejun Heo <tj@kernel.org> wrote: > On Wed, Mar 20, 2013 at 11:03:53PM +0800, Lai Jiangshan wrote: >> > +enomem: >> > + free_workqueue_attrs(tmp_attrs); >> > + if (pwq_tbl) { >> > + for_each_node(node) >> > + kfree(pwq_tbl[node]); >> >> It will free the dfl_pwq multi times. > > Oops, you're right. We need to do > > > for_eahc_node(node) > if (pwq_tbl[node] != dfl_pwq) > kfree(pwq_tbl[node]); > kfree(dfl_pwq);
I also missed. we still need to put_unbound_pool() before free(pwq)
> > Thanks! > > -- > tejun
| |