Messages in this thread | | | Date | Wed, 20 Mar 2013 19:02:30 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 2/2] regulator: palmas: add input supply names |
| |
On Wednesday 20 March 2013 06:55 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Mar 20, 2013 at 06:24:54PM +0530, Laxman Dewangan wrote: > >> The regulator core register the regulator even if there is NULL >> init_data and in this case, it tries to findout the input-supply >> (provided through desc->supply_name) and it fails to find out the >> supply handle and so regulator register fails cause all regulator >> registration to fail. >> So providing the dec->supply_name only in case of valid init_data. > This works fine if you have a device per regulator instead of a device > for all the regulators on the chip... I would be inclined to address > this by providing a "floating" supply and connecting everythinng to > that. I am fine with adding floating supply similar to below and connect all non-connected supply pins to this.
floating: regulator@1 { compatible = "regulator-fixed"; reg = <1>; regulator-name = "floating"; };
If this is fine then I will respin the patch to remove condition.
| |