lkml.org 
[lkml]   [2013]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux-next: build failure after merge of the tty tree
Date
From
Jiri Slaby writes:
>
> > drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
> > drivers/usb/serial/quatech2.c:661:18: error: 'struct
> > qt2_port_private' has no member named 'is_open'
> > drivers/usb/serial/quatech2.c:705:15: error: 'struct
> > qt2_port_private' has no member named 'is_open'
> >
> > Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded
> > is_open"). grep is your friend (or searching while editting the
> > file).
>
> I think this is caused by another commit. Bill added a check for
> is_open meanwhile I removed that member completely. Bill, could you
> fix that up, please?
>

Is it legal to call tty_flip_buffer_push() without an open tty? If
so, I can get rid of the is_open logic completely. Otherwise, I need
to either keep is_open or otherwise check for a valid tty before
calling tty_flip_buffer_push().

--
Bill


\
 
 \ /
  Last update: 2013-03-20 14:01    [W:0.043 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site