Messages in this thread Patch in this message | | | From | Richard Genoud <> | Subject | [PATCH] BUG: pinmux: forbid mux_usecount to be set at UINT_MAX | Date | Wed, 20 Mar 2013 12:31:52 +0100 |
| |
If pin_free is called on a pin already freed, mux_usecount is set to UINT_MAX which is really a bad idea. This will silently ignore a double call to pin_free
Signed-off-by: Richard Genoud <richard.genoud@gmail.com> --- drivers/pinctrl/pinmux.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 917e830..9fd55f9 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -194,8 +194,9 @@ static const char *pin_free(struct pinctrl_dev *pctldev, int pin, } if (!gpio_range) { - desc->mux_usecount--; - if (desc->mux_usecount) + if (1 == desc->mux_usecount) + desc->mux_usecount = 0; + else return NULL; } -- 1.7.2.5
| |