lkml.org 
[lkml]   [2013]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] f2fs: reduce unncessary locking pages during read
From
>
> - err = f2fs_readpage(sbi, page, dn.data_blkaddr, READ_SYNC);
> - if (err) {
> - f2fs_put_page(page, 1);
> - return ERR_PTR(err);
> + if (PageUptodate(page)) {
> + unlock_page(page);
> + return page;
> }
> - unlock_page(page);
Hi Jaegeuk.
> +
> + err = f2fs_readpage(sbi, page, dn.data_blkaddr, READ_SYNC);
> + wait_on_page_locked(page);
> + if (!PageUptodate(page))
> + return ERR_PTR(-EIO);
We don't need to release page before returning EIO ?

> return page;
> }
>
> @@ -241,9 +244,13 @@ struct page *get_lock_data_page(struct inode *inode,
> pgoff_t index)
> BUG_ON(dn.data_blkaddr == NULL_ADDR);
>
> err = f2fs_readpage(sbi, page, dn.data_blkaddr, READ_SYNC);
> - if (err) {
> - f2fs_put_page(page, 1);
> + if (err)
> return ERR_PTR(err);
Here is also same. We don't need to release page in case of err ?

Thanks.
> +
> + lock_page(page);
> + if (!PageUptodate(page)) {
> + f2fs_put_page(page, 1);
> + return ERR_PTR(-EIO);
> }
> return page;
> }


\
 
 \ /
  Last update: 2013-03-19 06:21    [W:0.052 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site