Messages in this thread Patch in this message | | | From | Dong Hao <> | Subject | [PATCH 2/3] lib/kobject: Panic when kobj or ktype is not properly assigned | Date | Tue, 19 Mar 2013 14:47:00 +0800 |
| |
From: Dong Hao <haodong@linux.vnet.ibm.com>
kobj and ktype are two important attributes which will be used after kobject_init(), and (!kobj)|(!ktype) may cause FS corruption which could not be recovered. Panic instead of dump_stack() when neither kobj nor ktype is properly assigned to detect the bug early.
Signed-off-by: Dong Hao <haodong@linux.vnet.ibm.com> --- lib/kobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/kobject.c b/lib/kobject.c index 279a172..ff9b3c3 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -290,7 +290,7 @@ void kobject_init(struct kobject *kobj, struct kobj_type *ktype) error: printk(KERN_ERR "kobject (%p): %s\n", kobj, err_str); - dump_stack(); + BUG_ON(1); } EXPORT_SYMBOL(kobject_init); -- 1.7.9.5
| |