lkml.org 
[lkml]   [2013]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] sparc: remove unused "config BITS"
From
From: Sam Ravnborg <sam@ravnborg.org>
Date: Tue, 19 Mar 2013 21:14:54 +0100

> On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote:
>> On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote:
>> > We use this in the Makefile fragments, you cannot remove it.
>>
>> >From arch/sparc/Makefile:
>> ifeq ($(CONFIG_SPARC32),y)
>> [...]
>>
>> [...]
>> export BITS := 32
>> [...]
>>
>> else
>> [...]
>>
>> [...]
>> export BITS := 64
>> [...]
>>
>> So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
>> Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
>> doesn't count as usage of "config BITS".
> Just double checked - you are right.
> Maybe send a v2 with this info in changelog and add my:
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

No need, I'll fix up the commit message.


\
 
 \ /
  Last update: 2013-03-19 22:41    [W:0.412 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site