Messages in this thread | | | From | Fabio Porcedda <> | Date | Tue, 19 Mar 2013 18:11:11 +0100 | Subject | Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe() |
| |
On Tue, Mar 19, 2013 at 5:48 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Tuesday 19 March 2013, Geert Uytterhoeven wrote: >> Hmm, so we may have drivers that (now) work perfectly fine with >> module_platform_driver_probe()/platform_driver_probe(), but will start >> failing suddenly in the future? > > They will fail if someone changes the initialization order. That would > already break drivers before deferred probing support (and was the reason > we added feature in the first place), but now we can be much more liberal > with the order in which drivers are initialized, except when they are > using platform_driver_probe() > >> I guess we need a big fat WARN_ON(-EPROBE_DEFER) in >> platform_driver_probe() to catch these? > > Yes, very good idea. > > Arnd
If it's fine, I'll send a patch for that.
Regards -- Fabio Porcedda
| |