Messages in this thread | | | Date | Tue, 19 Mar 2013 19:15:53 +0100 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 1/3] kernel/srcu: merge common code into a macro |
| |
On 03/19/2013 05:22 PM, Joe Perches wrote: >> +#define DEFINE_SRCU(name) _DEFINE_SRCU(name, ) >> +#define DEFINE_STATIC_SRCU(name) _DEFINE_SRCU(name, static) > > I think the use of an empty argument, even in > a macro, unsightly.
__wait_event_lock_irq() => __wait_event_lock_irq() is a prominent user. I would prefer to avoid adding something like /* nothing */.
Sebastian
| |