lkml.org 
[lkml]   [2013]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] rbtree_test: use pr_info for module prefix in messages
From
On Tue, Mar 19, 2013 at 11:14 AM, Davidlohr Bueso
<davidlohr.bueso@hp.com> wrote:
> On Tue, 2013-03-19 at 10:29 -0600, Shuah Khan wrote:
>> On Mon, Mar 18, 2013 at 5:20 PM, Davidlohr Bueso <davidlohr.bueso@hp.com> wrote:
>> > This provides nicer message output. Since it seems more appropriate
>> > for the nature of this module, also use KERN_INFO instead of other
>> > levels.
>>
>> Why are you changing the ALERTs to INFO?
>
> Because of the nature of the messages. They don't justify having a
> KERN_ALERT level (requiring immediate attention), and it seems a lot
> more suitable to use INFO instead.
>

Hmm. I see interval_tree_test using the same alerts. It almost looks
like the start and end of a test are meant to be alerts. I am not
saying it shouldn't be changed, however looking for a stronger reason
than "it seems a lot more suitable to use INFO instead". Are there any
use-cases in which KERN_ALERTs cause problems?

-- Shuah


\
 
 \ /
  Last update: 2013-03-19 19:21    [W:0.081 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site