Messages in this thread | | | Date | Tue, 19 Mar 2013 15:24:08 +0000 | From | "Jan Beulich" <> | Subject | Re: [Xen-devel] [PATCH 1/5] xen-blkback: don't store dev_bus_addr |
| |
>>> On 19.03.13 at 16:10, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > On Tue, Mar 19, 2013 at 02:55:56PM +0000, Jan Beulich wrote: >> >>> On 19.03.13 at 15:32, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: >> > @@ -971,7 +962,7 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif, >> > (bio_add_page(bio, >> > pages[i], >> > seg[i].nsec << 9, >> > - seg[i].buf & ~PAGE_MASK) == 0)) { >> > + seg[i].offset & ~PAGE_MASK) == 0)) { >> >> ... this one could as well use the original field. >> >> And the masking with ~PAGE_MASK is not pointless in any case. > > Good point. In which might as well make the 'struct seg_buf' be an > simple array of unsigned int.
Looks like you understood that the "not" in my earlier response was meant to be "now".
Jan
| |