Messages in this thread | | | Date | Tue, 19 Mar 2013 19:54:36 +0800 | Subject | Re: use after free in sysfs_find_dirent | From | Ming Lei <> |
| |
Hi Sasha,
On Tue, Mar 19, 2013 at 11:40 AM, Ming Lei <tom.leiming@gmail.com> wrote: > Hi Sasha, > > On Tue, Mar 19, 2013 at 10:06 AM, Sasha Levin <levinsasha928@gmail.com> wrote: >> [ 232.822703] sysfs_dir_pos-973 sysfs_dirent use after free: vx855(vx855)-bind, 0-25520352 > > Looks filp->f_pos is changed as zero by llseek(), so may leave > filp->private_data > point to one refcount-balanced sysfs_dirent object, which will be put > again afterwards. > > Hope we are luck this time, please try the attachment patch.
Looks the better and simpler way is to hold the i_mutex for llseek. If you haven't test the v2, please ignore it and just test the attachment v3 patch.
Thanks, -- Ming Lei [unhandled content-type:application/octet-stream] | |