lkml.org 
[lkml]   [2013]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] serial: 8250_dw: add support for clk api
Hi,

Le 19/03/2013 11:35, Maxime Ripard a écrit :
> From: Emilio López <emilio@elopez.com.ar>
>
> This commit implements support for using the clk api; this lets us use
> the "clocks" property with device tree, instead of having to use
> clock-frequency.
>
> Signed-off-by: Emilio López <emilio@elopez.com.ar>
> ---
> drivers/tty/serial/8250/8250_dw.c | 33 ++++++++++++++++++++++++---------
> 1 file changed, 24 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index db0e66f..3dedd24 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -26,6 +26,7 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/acpi.h>
> +#include <linux/clk.h>
>
> #include "8250.h"
>
> @@ -55,8 +56,9 @@
>
>
> struct dw8250_data {
> - int last_lcr;
> - int line;
> + int last_lcr;
> + int line;
> + struct clk *clk;
> };
>
> static void dw8250_serial_out(struct uart_port *p, int offset, int value)
> @@ -136,8 +138,13 @@ static int dw8250_probe_of(struct uart_port *p)
> if (!of_property_read_u32(np, "reg-shift", &val))
> p->regshift = val;
>
> + /* clock got configured through clk api, all done */
> + if (IS_ERR(p->uartclk))

Hmm, I messed up here.

I'll resend a new version of this mail without this IS_ERR call

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-03-19 12:43    [W:0.127 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site