Messages in this thread | | | Subject | Re: [PATCH] scheduler: convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s | From | Peter Zijlstra <> | Date | Tue, 19 Mar 2013 11:14:34 +0100 |
| |
On Mon, 2013-03-18 at 12:22 -0700, Tejun Heo wrote: > try_to_wake_up_local() should only be invoked to wake up another task > in the same runqueue and BUG_ON()s are used to enforce the rule. > Missing try_to_wake_up_local() can stall workqueue execution but such > stalls are likely to be finite either by another work item being > queued or the one blocked getting unblocked. There's no reason to > trigger BUG while holding rq lock crashing the whole system. > > Convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s.
Doesn't really matter either way, the printk()s triggered by either will very likely kill the system anyhow ;-)
| |