lkml.org 
[lkml]   [2013]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] extcon: max8997: add missing const
Date


> -----Original Message-----
> From: Sachin Kamat [mailto:sachin.kamat@linaro.org]
> Sent: Tuesday, March 19, 2013 12:33 PM
> To: Jingoo Han
> Cc: MyungJoo Ham; Chanwoo Choi; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] extcon: max8997: add missing const
>
> On 19 March 2013 07:33, Jingoo Han <jg1.han@samsung.com> wrote:
> > Fixed the checkpatch warning as below:
> >
> > WARNING: static const char * array should probably be static const char * const
> > #163: FILE: drivers/extcon/extcon-max8997.c:163:
> > +static const char *max8997_extcon_cable[] = {
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/extcon/extcon-max8997.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> > index 20772ad..6e8724f 100644
> > --- a/drivers/extcon/extcon-max8997.c
> > +++ b/drivers/extcon/extcon-max8997.c
> > @@ -160,7 +160,7 @@ enum {
> > _EXTCON_CABLE_NUM,
> > };
> >
> > -static const char *max8997_extcon_cable[] = {
> > +static const char const *max8997_extcon_cable[] = {
>
> Shouldn't this be "static const char * const max8997_extcon_cable[]"
> as suggested by checkpatch (as mentioned in your commit log)?

Hi Sachin Kamat,

Although the checkpatch warning is already fixed, I will send v2 patch
for clarity.

Thank you for your comment.

Best regards,
Jingoo Han

>
>
> --
> With warm regards,
> Sachin



\
 
 \ /
  Last update: 2013-03-19 05:21    [W:0.094 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site