Messages in this thread | | | Subject | Re: [PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL | From | Paul Bolle <> | Date | Mon, 18 Mar 2013 16:42:11 +0100 |
| |
On Sat, 2013-03-16 at 15:38 -0700, Kees Cook wrote: > Hrm, I actually think it would be better to change this to ERROR > instead of WARN.
I figured the main reason to add this warning was to prevent people to add dependencies on EXPERIMENTAL while you were cleaning the tree, which could mean you had to redo patches each time that happened.
Anyhow, with EXPERIMENTAL gone, this is just one of the mistakes people can make in using the kconfig system. I'm not sure that we should use checkpatch to catch these. For this particular case it must also be noted that if code gets in while still depending on EXPERIMENTAL someone also missed that this code doesn't get build at all.
Paul Bolle
| |