lkml.org 
[lkml]   [2013]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL
From
Date
On Sat, 2013-03-16 at 15:38 -0700, Kees Cook wrote:
> Hrm, I actually think it would be better to change this to ERROR
> instead of WARN.

I figured the main reason to add this warning was to prevent people to
add dependencies on EXPERIMENTAL while you were cleaning the tree, which
could mean you had to redo patches each time that happened.

Anyhow, with EXPERIMENTAL gone, this is just one of the mistakes people
can make in using the kconfig system. I'm not sure that we should use
checkpatch to catch these. For this particular case it must also be
noted that if code gets in while still depending on EXPERIMENTAL someone
also missed that this code doesn't get build at all.


Paul Bolle



\
 
 \ /
  Last update: 2013-03-18 17:21    [W:0.058 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site