lkml.org 
[lkml]   [2013]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/8]Perf: Transform evlist->mmap to xyarray
On 3/13/13 3:42 AM, chenggang wrote:
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index a2108ca..7f3f066 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -209,7 +209,8 @@ BASIC_CFLAGS = \
> -Iutil \
> -I. \
> -I$(TRACE_EVENT_DIR) \
> - -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
> + -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE \
> + -std=gnu99

Why is this needed? at best it should be a separate patch just changing
the Makefile.


>
> BASIC_LDFLAGS =
>

Take my comments from your patch 1 of this version and apply here as
well. e.g., in smaller patches introduce APIs to consolidate existing
references. Once done change the implementation.


David


\
 
 \ /
  Last update: 2013-03-18 01:01    [W:0.087 / U:2.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site