Messages in this thread | | | Date | Mon, 18 Mar 2013 08:26:48 +1100 | From | Paul Mackerras <> | Subject | Re: [PATCH 1/9] powerpc,kvm: fix imbalance srcu_read_[un]lock() |
| |
On Sat, Mar 16, 2013 at 12:50:49AM +0800, Lai Jiangshan wrote: > At the point of up_out label in kvmppc_hv_setup_htab_rma(), > srcu read lock is still held. > > We have to release it before return. > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > Cc: Marcelo Tosatti <mtosatti@redhat.com> > Cc: Gleb Natapov <gleb@redhat.com> > Cc: Alexander Graf <agraf@suse.de> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: kvm@vger.kernel.org > Cc: kvm-ppc@vger.kernel.org > --- > arch/powerpc/kvm/book3s_hv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 80dcc53..c26740e 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -1799,7 +1799,7 @@ static int kvmppc_hv_setup_htab_rma(struct kvm_vcpu *vcpu) > > up_out: > up_read(¤t->mm->mmap_sem); > - goto out; > + goto out_srcu;
Acked-by: Paul Mackerras <paulus@samba.org>
| |