Messages in this thread | | | Date | Sun, 17 Mar 2013 18:25:50 +0000 | From | Al Viro <> | Subject | Re: [PATCH] uprobes: Use file_inode() |
| |
On Sun, Mar 17, 2013 at 07:00:36PM +0100, Oleg Nesterov wrote: > Cleanup. Now that we have f_inode/file_inode() we can use it > instead of ->f_mapping->host.
No. This is *not* guaranteed to be the same thing in general; note that e.g. for block devices ->f_mapping->host is *not* equal to file_inode(). It probably is valid in this particular case, but at the very least you need to explain that in commit message, or soon we'll get the Knights of Holy Commit Count(tm) crapping all over the tree, breaking stuff.
| |