lkml.org 
[lkml]   [2013]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/50] staging: omap-thermal: several code refactoring
Hello Dan,

On 16-03-2013 05:05, Dan Carpenter wrote:
> I've reviewed this set.
>
> I hate to make people redo whole patchset sets, and I hate
> re-reviewing code. Obviously, I don't really like the bunny hop
> patches and I'm trying to discourage that going forward. ;P But
> I wouldn't say it's a "Redo the whole thing" kind of problem.
>
> Could just resend patch 33 and 47? You should probably be able to
> redo those without changing the rest.

I could of course change them if the comment is better clarified. As I
mentioned as reply to one of your comments, those changes are following
what is suggested in CodingStyle file.

I can of course send a diff on top of 33, to fix the introduce bug.

For 47, I'm not sure the comment is fully applicable.

>
> regards,
> dan carpenter
>
>
>



\
 
 \ /
  Last update: 2013-03-16 14:21    [W:0.191 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site