Messages in this thread | | | Date | Fri, 15 Mar 2013 10:10:00 +0530 | From | Ananth N Mavinakayanahalli <> | Subject | Re: [PATCH -tip v2 1/2] [BUGFIX] kprobes: make hash_64() as always inlined |
| |
On Thu, Mar 14, 2013 at 08:52:30PM +0900, Masami Hiramatsu wrote: > Because hash_64() is called from the get_kprobe() inside > int3 handler, kernel causes int3 recursion and crashes if > kprobes user puts a probe on it. > > Usually hash_64() is inlined into caller function, but in > some cases, it has instances by gcc's interprocedural > constant propagation. > > This patch uses __always_inline instead of inline to > prevent gcc from doing such things. > > Changes in v2: > - Use __always_inline instead of using __kprobes > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > Reported-by: Timo Juhani Lindfors <timo.lindfors@iki.fi> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Nadia Yvette Chambers <nyc@holomorphy.com> > Cc: Pavel Emelyanov <xemul@parallels.com> > Cc: Jiri Kosina <jkosina@suse.cz> > Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
| |