Messages in this thread | | | Date | Fri, 15 Mar 2013 07:26:35 +0100 | Subject | Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS | From | Geert Uytterhoeven <> |
| |
On Thu, Mar 14, 2013 at 10:56 PM, Arnd Bergmann <arnd@arndb.de> wrote: > Disabling CONFIG_VIRT_TO_BUS on ARM showed that the hisax netjet > driver depends on this deprecated functionality but is not > marked so in Kconfig. > > Rather than adding ARM to the already long list of architectures > that this driver is broken on, this patch adds 'depends on > VIRT_TO_BUS' and removes the dependency on !SPARC, which is > also implied by that.
IIRC, the real "arch" dependency for this driver is !BIG_ENDIAN, but unfortunately we don't have a generic Kconfig symbol for that. Perhaps we may want to introduce that? Of course we prefer to make drivers work on all endianness instead...
> --- a/drivers/isdn/hisax/Kconfig > +++ b/drivers/isdn/hisax/Kconfig > @@ -237,7 +237,8 @@ config HISAX_MIC > > config HISAX_NETJET > bool "NETjet card" > - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) > + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) > + depends on VIRT_TO_BUS > help > This enables HiSax support for the NetJet from Traverse > Technologies. > @@ -248,7 +249,8 @@ config HISAX_NETJET > > config HISAX_NETJET_U > bool "NETspider U card" > - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) > + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) > + depends on VIRT_TO_BUS
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |