lkml.org 
[lkml]   [2013]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc/qe: remove useless Kconfig default
From
Date

On Mar 12, 2013, at 4:49 PM, Paul Bolle wrote:

> The Kconfig entry for QE_USB contains
> default y if USB_GADGET_FSL_QE
>
> But USB_GADGET_FSL_QE got removed in commit
> 193ab2a6070039e7ee2b9b9bebea754a7c52fd1b ("usb: gadget: allow multiple
> gadgets to be built"). This default will therefor never be set and can
> be removed.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested with "make ARCH=powerpc menuconfig" and "make ARCH=powerpc
> oldconfig" (before and after the patch). Enough to see this patch didn't
> obviously break stuff.
>
> 1) I don't really understand commit
> 193ab2a6070039e7ee2b9b9bebea754a7c52fd1b. Was its point that we replace
> USB_GADGET_FSL_QE with USB_FSL_QE? I couldn't tell and chose not to
> actually change any behavior.
>
> arch/powerpc/sysdev/qe_lib/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>

You're correct that this isn't quite right, I've posted a proper patch that should fix this correctly.

thanks for pointing it out.

- k

\
 
 \ /
  Last update: 2013-03-15 18:01    [W:0.048 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site