Messages in this thread | | | Subject | Re: [PATCH] phy: Elimination the forced speed reduction algorithm. | From | Joe Perches <> | Date | Fri, 15 Mar 2013 05:48:49 -0700 |
| |
On Fri, 2013-03-15 at 08:35 -0400, David Miller wrote: > From: Kirill Kapranov <kapranoff@inbox.ru> > Date: Thu, 14 Mar 2013 14:40:52 +0400 > > > @@ -867,7 +821,6 @@ void phy_state_machine(struct work_struct *work) > > netif_carrier_on(phydev->attached_dev); > > } else { > > if (0 == phydev->link_timeout--) { > > - phy_force_reduction(phydev); > > needs_aneg = 1; > > } > > This is not a single-statement basic block, and therefore you > should remove the surrounding braces.
s/not/now/
The phy code also uses non standard kernel style tests like if (CONSTANT == variable) instead of if (variable == CONSTANT)
| |