Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH]Perf: Fix Makefile to remove all "*.o" files while "make clean" | Date | Thu, 14 Mar 2013 17:41:16 +0900 |
| |
Hi chenggang,
On Thu, 14 Mar 2013 13:56:05 +0800, chenggang wrote: > From: chenggang <chenggang.qcg@taobao.com> > > While we run "make clean" in perf's directory, and run the command: > "fine ./ -name *.o" > we will get: > ------------------------------------ > ./arch/x86/util/unwind.o > ./arch/x86/util/header.o > ./arch/x86/util/dwarf-regs.o > ./util/scripting-engines/trace-event-python.o > ./util/scripting-engines/trace-event-perl.o > ./util/probe-finder.o > ./util/dwarf-aux.o > ./util/unwind.o > ./lib/rbtree.o > ./ui/browser.o > ./ui/browsers/map.o > ./ui/browsers/annotate.o > ./ui/browsers/scripts.o > ./ui/browsers/hists.o > ./ui/tui/setup.o > ./ui/tui/util.o > ./ui/tui/helpline.o > ./ui/tui/progress.o > ./ui/gtk/browser.o > ./ui/gtk/setup.o > ./ui/gtk/util.o > ./ui/gtk/helpline.o > ./ui/gtk/annotate.o > ./ui/gtk/progress.o > ./ui/gtk/hists.o > ./scripts/perl/Perf-Trace-Util/Context.o > ./scripts/python/Perf-Trace-Util/Context.o > ------------------------------------ > These ".o" files are not cleaned. > > This patch fixed this problem.
Hmm... They should be in $LIB_OBJS which already included in the recipe. I guess it's missed because we skip the feature tests for "clean" (and "tags" too) target now. Sigh.
Thanks, Namhyung
| |