Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 6/6] perf util: Change trace info output file name | Date | Thu, 14 Mar 2013 17:23:08 +0900 |
| |
Hi David,
On Wed, 13 Mar 2013 07:47:16 -0600, David Ahern wrote: > On 3/13/13 5:19 AM, Namhyung Kim wrote: >> -static const char *output_file = "trace.info"; >> +static const char *output_file = "perf.data"; >> static int output_fd; > > Not really needed. Only use is a couple of die() calls. Since the file > name is not used on the open the die message would be misleading.
I know. But it just looked too ugly to me. :)
I'm fine with dropping this one. I think I'm going to get rid of these die() and something_or_die() calls soonish..
Thanks, Namhyung
| |