lkml.org 
[lkml]   [2013]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] regmap: Cut down on the average # of nodes in the rbtree cache
On Thu, Mar 14, 2013 at 02:52:35PM +0000, Dimitris Papastamos wrote:

> if (rbnode) {
> reg_tmp = (reg - rbnode->base_reg) / map->reg_stride;
> + /* Does this register exist? If not bail out. */
> + if (!(rbtree_ctx->reg_present[BIT_WORD(reg)] & BIT_MASK(reg)))
> + return -ENOENT;
> *value = regcache_rbtree_get_register(map, rbnode, reg_tmp);

This means that every caller is going to need to have a check added to
see if the register is present which doesn't seem great, we should at
least have a function to do the check. The check is fiddly enough.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-03-15 03:21    [W:0.069 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site