lkml.org 
[lkml]   [2013]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 30/88] target/pscsi: Fix page increment
    Date
    3.5.7.8 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Asias He <asias@redhat.com>

    commit 472b72f2db7831d7dbe22ffdff4adee3bd49b05d upstream.

    The page++ is wrong. It makes bio_add_pc_page() pointing to a wrong page
    address if the 'while (len > 0 && data_len > 0) { ... }' loop is
    executed more than one once.

    Signed-off-by: Asias He <asias@redhat.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/target/target_core_pscsi.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
    index 4ce2cf6..1835d84 100644
    --- a/drivers/target/target_core_pscsi.c
    +++ b/drivers/target/target_core_pscsi.c
    @@ -1000,7 +1000,6 @@ static int pscsi_map_sg(struct se_cmd *cmd, struct scatterlist *sgl,
    bio = NULL;
    }

    - page++;
    len -= bytes;
    data_len -= bytes;
    off = 0;
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-03-14 19:41    [W:2.941 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site